Skip to content
This repository was archived by the owner on Oct 22, 2025. It is now read-only.

Drop GH token from README#46

Merged
henryju merged 1 commit intomasterfrom
feature/bogdana/SC-6818-github-token
May 23, 2024
Merged

Drop GH token from README#46
henryju merged 1 commit intomasterfrom
feature/bogdana/SC-6818-github-token

Conversation

@bogdanakushnir
Copy link
Contributor

No description provided.

@henryju henryju force-pushed the feature/bogdana/SC-6818-github-token branch from de12c4a to 3073358 Compare May 23, 2024 10:00
@henryju henryju merged commit 4006f66 into master May 23, 2024
@henryju henryju deleted the feature/bogdana/SC-6818-github-token branch May 23, 2024 10:02
@t3chguy
Copy link

t3chguy commented Dec 4, 2024

Any context for this? Is GITHUB_TOKEN no longer necessary to be passed? https://github.com/SonarSource/sonarcloud-github-action#secrets still refers to GITHUB_TOKEN which just increases confusion. Nothing in the release notes to explain anything https://github.com/SonarSource/sonarcloud-github-action/releases/tag/v2.2

@henryju
Copy link
Member

henryju commented Dec 4, 2024

It might have been necessary a long time ago for PR decoration, but we could not find a use case for it anymore.
We might have left some references that we forgot to clean, we will double-check, thanks (cc @antonioaversa ).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants