Skip to content

PLUGINAPI-152 Migrate to GitHub Actions#260

Merged
claire-villard-sonarsource merged 1 commit intomasterfrom
claire/PLUGINAPI-152/migrate-to-gha
Nov 25, 2025
Merged

PLUGINAPI-152 Migrate to GitHub Actions#260
claire-villard-sonarsource merged 1 commit intomasterfrom
claire/PLUGINAPI-152/migrate-to-gha

Conversation

@claire-villard-sonarsource
Copy link
Copy Markdown
Contributor

@claire-villard-sonarsource claire-villard-sonarsource commented Nov 24, 2025

Content

  • Migrate the build and promote tasks to GHA
  • The Build number has been updated
image
  • The required checks don't need any change
  • The build is 🟢

For SonarSourcers:

Check before making the PR ready for review

  • Create a JIRA ticket if the API is impacted
  • Prefix the commit message with the ticket number
  • Document the change in CHANGELOG.md
  • When adding a new API:
    • Explain in the JavaDoc the purpose of the new API
    • Add a @since X.Y in the JavaDoc
  • When deprecating an API:
    • Annotate the deprecated element with @Deprecated
    • Add a @deprecated since X.Y in the JavaDoc
    • Document the replacement in the JavaDoc (if any)
  • When dropping an API:
  • Make sure the tests adhere to the convention:
    • All test method names should use snake_case, for example: test_validate_input. It can also start with the methodName
  • Make sure checks are green: build passes, Quality Gate is green
  • Merge after getting approval by at least one member of the guild
    • If no review is made within 3 days, gently ping the reviewers
    • The guild member reviewing the code can explicitly request someone else (typically another guild member representing another team) to check the impact on the specific product
    • In some cases, the guild may deem it necessary that multiple or even all members approve a PR. This is more likely in complex changes or changes directly impacting all teams using the API.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod bot commented Nov 24, 2025

PLUGINAPI-152

@sonarqube-next
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@antoine-vinot-sonarsource antoine-vinot-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claire-villard-sonarsource claire-villard-sonarsource merged commit 286b9a8 into master Nov 25, 2025
8 checks passed
@claire-villard-sonarsource claire-villard-sonarsource deleted the claire/PLUGINAPI-152/migrate-to-gha branch November 25, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants