Skip to content

PLUGINAPI-164 Introduce support for feature availability checks#247

Merged
antoine-vinot-sonarsource merged 1 commit intomasterfrom
task/mm/feature-flag
Oct 29, 2025
Merged

PLUGINAPI-164 Introduce support for feature availability checks#247
antoine-vinot-sonarsource merged 1 commit intomasterfrom
task/mm/feature-flag

Conversation

@matteo-mara-sonarsource
Copy link
Copy Markdown
Contributor

@matteo-mara-sonarsource matteo-mara-sonarsource commented Sep 10, 2025

PLUGINAPI-164

For SonarSourcers:

Check before making the PR ready for review

  • Create a JIRA ticket if the API is impacted
  • Prefix the commit message with the ticket number
  • Document the change in CHANGELOG.md
  • When adding a new API:
    • Explain in the JavaDoc the purpose of the new API
    • Add a @since X.Y in the JavaDoc
  • Make sure the tests adhere to the convention:
    • All test method names should use snake_case, for example: test_validate_input. It can also start with the methodName
  • Make sure checks are green: build passes, Quality Gate is green
    • If no review is made within 3 days, gently ping the reviewers
    • The guild member reviewing the code can explicitly request someone else (typically another guild member representing another team) to check the impact on the specific product
    • In some cases, the guild may deem it necessary that multiple or even all members approve a PR. This is more likely in complex changes or changes directly impacting all teams using the API.

@matteo-mara-sonarsource matteo-mara-sonarsource requested a review from a team as a code owner September 10, 2025 21:12
@sonarqube-next
Copy link
Copy Markdown

@matteo-mara-sonarsource matteo-mara-sonarsource marked this pull request as draft September 30, 2025 08:50
@antoine-vinot-sonarsource antoine-vinot-sonarsource changed the title DO NOT MERGE Part of the tests regarding the feature flags accessible from the analyzers PLUGINAPI-164 Introduce support for feature availability checks Oct 29, 2025
@sonarqube-next
Copy link
Copy Markdown

@antoine-vinot-sonarsource antoine-vinot-sonarsource marked this pull request as ready for review October 29, 2025 11:01
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antoine-vinot-sonarsource antoine-vinot-sonarsource merged commit 02e36d1 into master Oct 29, 2025
7 checks passed
@antoine-vinot-sonarsource antoine-vinot-sonarsource deleted the task/mm/feature-flag branch October 29, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants