BUILD-10724: GitHub→S3 cache migration fallback by julien-carsique-sonarsource · Pull Request #125 · SonarSource/sonar-dummy-js

julien-carsique-sonarsource · 2026-03-18T17:09:55Z

Tests the import-github-cache feature introduced in SonarSource/gh-action_cache#45
Also depends on SonarSource/ci-github-actions#236

Migrate sonar-dummy-js to S3 cache

What is being tested

Scenario	Description
`test-s3-import-enabled`	S3 backend, import mode active (default) — migration fallback in action
`test-s3-import-disabled`	S3 backend, `import-github-cache: false` — post-migration behaviour
`test-s3-import-disabled-via-env`	S3 backend, `CACHE_IMPORT_GITHUB=false` env var — repo variable pattern

# Build
## S3 backend and import mode ON
Using default import mode: true

## S3 lookup
Cache not found for input keys: test/jcarsique/BUILD-10724-migrationGh2s3/npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0, test/jcarsique/BUILD-10724-migrationGh2s3/npm-Linux-Build-

## GitHub lookup
Cache hit for: npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0
Cache restored from key: npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0

## Post Run
Cache saved with key: test/jcarsique/BUILD-10724-migrationGh2s3/npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0
---
# Custom NPM command
## S3 lookup
Cache restored from key: test/jcarsique/BUILD-10724-migrationGh2s3/npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0

## Post Run
Cache hit occurred on the primary key test/jcarsique/BUILD-10724-migrationGh2s3/npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0, not saving cache.

✔️ No need for migration in the second run.

# Build
## S3 lookup
Cache restored successfully
Cache restored from key: test/jcarsique/BUILD-10724-migrationGh2s3/npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0

## Post Run
Cache hit occurred on the primary key test/jcarsique/BUILD-10724-migrationGh2s3/npm-Linux-Build-655c2e22a7bceb4cba87bd33429d34e2ab54e41f19dab78fad56d9bc645173e0, not saving cache.

Tests the new import-github-cache feature from gh-action_cache: - S3 backend with import mode active (default migration behaviour) - S3 backend with import mode explicitly disabled (post-migration) - S3 backend with import mode disabled via CACHE_IMPORT_GITHUB env var Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

sonar-review-alpha · 2026-03-25T17:44:37Z

Summary

Tests the migration fallback mechanism for the cache backend transition (GitHub → S3). A new workflow validates three scenarios: (1) S3 with GitHub cache import enabled (default, tests the fallback feature), (2) S3 with import explicitly disabled, and (3) S3 with import disabled via environment variable. The test provisions a GitHub cache entry, then verifies that each scenario behaves correctly. Also updates existing workflows to force S3 backend globally.

What reviewers should know

Start here: Review the new test-cache-migration-gh2s3.yml workflow to understand what's being validated. The test design is clever: it uses provision-github-cache to create a shared GitHub cache entry that scenarios 1–3 then attempt to restore under different configurations. Key details: (1) Scenario 1 succeeds (cache-hit: true) because import is enabled by default—this verifies the fallback works. (2) Scenarios 2 and 3 intentionally fail to import to verify the migration is complete. (3) The rm -rf ~/.npm cleanup in scenario 1 prevents test pollution. (4) Two disable patterns are tested to support both explicit configuration and environment variables (useful for repos using GitHub environment variables). The CACHE_BACKEND: s3 env var in build.yml and unified-dogfooding.yml ensures all cache steps use S3, including those from reused actions.

Generate Walkthrough
Generate Diagram

🗣️ Give feedback

Copilot

Pull request overview

Adds workflows and configuration to dogfood and validate the GitHub→S3 cache migration fallback behavior for SonarSource/gh-action_cache, while switching this repo’s CI workflows to force the S3 cache backend.

Changes:

Force S3 caching in existing CI workflows via workflow-level CACHE_BACKEND: s3.
Add a dedicated test workflow to exercise migration fallback and import-disabled modes (including env-var disabling).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
.github/workflows/unified-dogfooding.yml	Forces S3 cache backend for unified dogfooding runs via `CACHE_BACKEND`.
.github/workflows/build.yml	Forces S3 cache backend for build pipeline via `CACHE_BACKEND`.
.github/workflows/test-cache-migration-gh2s3.yml	Adds a test matrix-style workflow to validate GitHub→S3 import fallback and disabling mechanisms.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/test-cache-migration-gh2s3.yml

bwalsh434

LGTM, more tests 👍

sonar-review-alpha

Conclusion: Clean, well-structured PR. The production changes are minimal (two one-liner env additions), and the test workflow is thorough and correctly designed for its purpose.

🗣️ Give feedback

sonarqube-next · 2026-03-26T09:59:49Z

Quality Gate passed for 'sonar-dummy-js'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

julien-carsique-sonarsource added the DO NOT MERGE label Mar 18, 2026

julien-carsique-sonarsource mentioned this pull request Mar 18, 2026

BUILD-10724: Import GitHub cache to S3 (migration fallback) SonarSource/gh-action_cache#45

Merged

julien-carsique-sonarsource force-pushed the test/jcarsique/BUILD-10724-migrationGh2s3 branch 6 times, most recently from 2cc4fb5 to 540d520 Compare March 24, 2026 10:48

julien-carsique-sonarsource force-pushed the test/jcarsique/BUILD-10724-migrationGh2s3 branch from 62396c0 to d2e1fcf Compare March 25, 2026 10:13

julien-carsique-sonarsource changed the title ~~[TEST] BUILD-10724: GitHub→S3 cache migration fallback~~ BUILD-10724: GitHub→S3 cache migration fallback Mar 25, 2026

julien-carsique-sonarsource force-pushed the test/jcarsique/BUILD-10724-migrationGh2s3 branch from d2e1fcf to 0f073d2 Compare March 25, 2026 16:58

julien-carsique-sonarsource removed the DO NOT MERGE label Mar 25, 2026

julien-carsique-sonarsource marked this pull request as ready for review March 25, 2026 17:44

Copilot AI review requested due to automatic review settings March 25, 2026 17:44

Copilot started reviewing on behalf of julien-carsique-sonarsource March 25, 2026 17:44 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

bwalsh434 approved these changes Mar 25, 2026

View reviewed changes

sonar-review-alpha bot reviewed Mar 25, 2026

View reviewed changes

BUILD-10726 use S3 cache

0406398

julien-carsique-sonarsource force-pushed the test/jcarsique/BUILD-10724-migrationGh2s3 branch from 0f073d2 to 0406398 Compare March 26, 2026 09:58

julien-carsique-sonarsource merged commit 3c7a60a into master Mar 26, 2026
9 of 10 checks passed

julien-carsique-sonarsource deleted the test/jcarsique/BUILD-10724-migrationGh2s3 branch March 26, 2026 10:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUILD-10724: GitHub→S3 cache migration fallback#125

BUILD-10724: GitHub→S3 cache migration fallback#125
julien-carsique-sonarsource merged 2 commits intomasterfrom
test/jcarsique/BUILD-10724-migrationGh2s3

julien-carsique-sonarsource commented Mar 18, 2026 •

edited

Loading

Uh oh!

julien-carsique-sonarsource commented Mar 24, 2026 •

edited

Loading

Uh oh!

sonar-review-alpha bot commented Mar 25, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bwalsh434 left a comment

Uh oh!

sonar-review-alpha bot left a comment

Uh oh!

sonarqube-next bot commented Mar 26, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

julien-carsique-sonarsource commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is being tested

Related

Uh oh!

julien-carsique-sonarsource commented Mar 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonar-review-alpha bot commented Mar 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

What reviewers should know

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bwalsh434 left a comment

Choose a reason for hiding this comment

Uh oh!

sonar-review-alpha bot left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqube-next bot commented Mar 26, 2026

Quality Gate passed for 'sonar-dummy-js'

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

julien-carsique-sonarsource commented Mar 18, 2026 •

edited

Loading

julien-carsique-sonarsource commented Mar 24, 2026 •

edited

Loading

sonar-review-alpha bot commented Mar 25, 2026 •

edited

Loading