Skip to content

ACOMMONS-35 Remove commons-lang dependency#371

Merged
quentin-jaquier-sonarsource merged 3 commits intomasterfrom
NG/update-apache-commons
Oct 31, 2025
Merged

ACOMMONS-35 Remove commons-lang dependency#371
quentin-jaquier-sonarsource merged 3 commits intomasterfrom
NG/update-apache-commons

Conversation

@nicolas-gauthier-sonarsource
Copy link
Copy Markdown
Contributor

@nicolas-gauthier-sonarsource nicolas-gauthier-sonarsource commented Oct 31, 2025

ACOMMONS-35

Part of

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Replace commons-lang with commons-text ACOMMONS-35 Replace commons-lang with commons-text Oct 31, 2025
@nicolas-gauthier-sonarsource nicolas-gauthier-sonarsource marked this pull request as ready for review October 31, 2025 08:36
Copy link
Copy Markdown
Contributor

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we are at it, why not going one step further and getting rid completely of the external dependency?
We basically only use it for writing \\ instead of \\\\. And this is used inconsistently in the tests, I would find it cleaner to not rely on this dependency, and be explicit. The only case that is worth is probably longEmailRegex in intersects_and_superset_of_complex_expression, but we can simply use longEmailRegex = longEmailRegex.replaceAll("\\\\", "\\\\\\\\"); for this one.

@nicolas-gauthier-sonarsource nicolas-gauthier-sonarsource changed the title ACOMMONS-35 Replace commons-lang with commons-text ACOMMONS-35 Remove commons-lang dependecy Oct 31, 2025
@sonarqube-next
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this change and taking into account my comments 😄
Less dependency and more consistency 🚀
LGTM

@quentin-jaquier-sonarsource quentin-jaquier-sonarsource changed the title ACOMMONS-35 Remove commons-lang dependecy ACOMMONS-35 Remove commons-lang dependency Oct 31, 2025
@quentin-jaquier-sonarsource quentin-jaquier-sonarsource merged commit 2f8afc0 into master Oct 31, 2025
7 checks passed
@quentin-jaquier-sonarsource quentin-jaquier-sonarsource deleted the NG/update-apache-commons branch October 31, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants