PARENTOSS-117 use BUILD_NUMBER#271
Merged
julien-carsique-sonarsource merged 1 commit intomasterfrom Jul 17, 2025
Merged
Conversation
Use BUILD_NUMBER first for buildInfo.buildNumber and deployProperties.build.number, before other fallback variables Use GITHUB_SHA first for deployProperties.vcs.revision and buildInfo.vcsRevision Use GITHUB_REF first for deployProperties.vcs.branch Also collect environment variables with patterns: GITHUB_SHA, GITHUB_*REF*, GITHUB_REPOSITORY, GITHUB_RUN* Sort envVarsIncludePatterns
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Maven configuration to prioritize GitHub Actions environment variables in the build and deployment process. The changes ensure that GitHub-specific environment variables are used first before falling back to other CI/CD platform variables.
- Reorders environment variable patterns to be alphabetically sorted
- Adds GitHub-specific environment variable patterns (GITHUB_REF, GITHUB_REPOSITORY, GITHUB_RUN*)
- Prioritizes BUILD_NUMBER, GITHUB_SHA, and GITHUB_REF in deployment properties and build info configurations
|
matemoln
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PARENTOSS-117
Use BUILD_NUMBER first for buildInfo.buildNumber and deployProperties.build.number, before other fallback variables
Use GITHUB_SHA first for deployProperties.vcs.revision and buildInfo.vcsRevision
Use GITHUB_REF first for deployProperties.vcs.branch
Also collect environment variables with patterns: GITHUB_SHA, GITHUB_REF, GITHUB_REPOSITORY, GITHUB_RUN*
Sort envVarsIncludePatterns