Skip to content

squid: save metrics slow#2520

Merged
guwirth merged 2 commits intoSonarOpenCommunity:masterfrom
guwirth:squid-save
May 9, 2023
Merged

squid: save metrics slow#2520
guwirth merged 2 commits intoSonarOpenCommunity:masterfrom
guwirth:squid-save

Conversation

@guwirth
Copy link
Copy Markdown
Collaborator

@guwirth guwirth commented May 9, 2023 •
edited by SonarOpenCommunityAdmin
Loading

try to solve performance issue with squid save (#2502)

This change is Reviewable

@guwirth
squid save slow
601fe87 
try to solve performance issue with squid save
@guwirth guwirth added the bug label May 9, 2023
@guwirth guwirth added this to the 2.1.1 milestone May 9, 2023
@guwirth guwirth self-assigned this May 9, 2023
@guwirth guwirth changed the title squid save slow squid: save metrics slow May 9, 2023
@guwirth guwirth mentioned this pull request May 9, 2023
Closed
@Nekto89
Copy link
Copy Markdown
Contributor

Nekto89 commented May 9, 2023 •
edited
Loading

I've tried building it locally but "mvn clean install" gives error. Is there some link that I can use to download prebuilt plugin?

[ERROR] Tests run: 10, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.034 s <<< FAILURE! - in com.sonar.cxx.sslr.impl.typed.InterceptorTest
[ERROR] requires_final_methods_to_be_non_public  Time elapsed: 0.019 s  <<< FAILURE!
java.lang.AssertionError:

Expecting actual throwable to be an instance of:
  java.lang.VerifyError
but was:
  java.lang.IncompatibleClassChangeError: class GeneratedBySSLR overrides final method com.sonar.cxx.sslr.impl.typed.InterceptorTest$PublicFinalMethod.m()Ljava/lang/Object;
        at java.base/java.lang.ClassLoader.defineClass1(Native Method)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1012)
        at java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:874)
        ...(73 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
        at com.sonar.cxx.sslr.impl.typed.InterceptorTest.requires_final_methods_to_be_non_public(InterceptorTest.java:170)

UPD nvm, I was able to build it with Java JDK 11 instead of 17. I will try it today.

@guwirth
Copy link
Copy Markdown
Collaborator Author

guwirth commented May 9, 2023

Hi @Nekto89,

you can download it from here
https://github.com/SonarOpenCommunity/sonar-cxx/actions/runs/4924552763

JAR_Files:
https://github.com/SonarOpenCommunity/sonar-cxx/suites/12769308245/artifacts/686739059

Regards,

@guwirth guwirth merged commit 1345a4d into SonarOpenCommunity:master May 9, 2023
@guwirth guwirth deleted the squid-save branch June 7, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@guwirth guwirth

Labels

bug

Milestone

2.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@guwirth @Nekto89