Skip to content

Use VAR=value to set implicit variables in Makefile#106

Merged
mato merged 1 commit intoSolo5:masterfrom
mato:minor-makefile
Oct 20, 2016
Merged

Use VAR=value to set implicit variables in Makefile#106
mato merged 1 commit intoSolo5:masterfrom
mato:minor-makefile

Conversation

@mato
Copy link
Copy Markdown
Member

@mato mato commented Oct 20, 2016

VAR?=value does not do what we thought it did.

VAR?=value does not do what we thought it did.
@hannesm
Copy link
Copy Markdown
Contributor

hannesm commented Oct 20, 2016

this is fine, but do we actually need those bindings (make provides exactly the same ones, no need to re-bind)... apart from objcopy afaics (see also https://www.gnu.org/software/make/manual/make.html#Implicit-Variables which for some reason does not list LD)

@mato
Copy link
Copy Markdown
Member Author

mato commented Oct 20, 2016

I'd like to keep the bindings in Makefile.common just to make it obvious to the user that is the place to set them.

@hannesm
Copy link
Copy Markdown
Contributor

hannesm commented Oct 20, 2016

LGTM

@mato mato merged commit c6e79f7 into Solo5:master Oct 20, 2016
@mato mato deleted the minor-makefile branch October 20, 2016 09:06
@hannesm hannesm mentioned this pull request Nov 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants