Skip to content

Conversation

@pierredup
Copy link
Member

Use the client currency in all places where values needs to display.

Fixes #2183

@pierredup pierredup added this to the 2.3.11 milestone Dec 9, 2025
@pierredup pierredup added the bug label Dec 9, 2025
@solidinvoice-bot
Copy link

solidinvoice-bot bot commented Dec 9, 2025

The preview deployment for solidinvoice is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2025-12-09 18:58:47 CET

@pierredup pierredup changed the base branch from 2.4.x to 2.3.x December 9, 2025 18:56
@pierredup pierredup force-pushed the fix-display-currency branch from e20817d to b7c5303 Compare December 9, 2025 18:58
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.74%. Comparing base (0c495e3) to head (2b8c13b).
⚠️ Report is 2 commits behind head on 2.3.x.

Files with missing lines Patch % Lines
src/ClientBundle/Twig/Components/ClientCredit.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              2.3.x    #2187      +/-   ##
============================================
+ Coverage     47.72%   47.74%   +0.02%     
- Complexity     2754     2755       +1     
============================================
  Files           502      502              
  Lines          9318     9326       +8     
============================================
+ Hits           4447     4453       +6     
- Misses         4871     4873       +2     
Flag Coverage Δ
unittests 47.74% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pierredup pierredup changed the title Fix performance issues when loading api tokens Fix displaying incorrect currency in some areas Dec 9, 2025
@pierredup pierredup merged commit 970db30 into 2.3.x Dec 9, 2025
28 checks passed
@pierredup pierredup deleted the fix-display-currency branch December 9, 2025 20:12
@codecov
Copy link

codecov bot commented Dec 9, 2025

Bundle Report

Changes will decrease total bundle size by 408.77kB (-5.12%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
solidinvoice-webpack-bundle-array-push 7.57MB -408.77kB (-5.12%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: solidinvoice-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
app.*.css -555 bytes 1.36MB -0.04%
email.*.css -152.22kB 504.16kB -23.19%
pdf.*.css -152.22kB 445.21kB -25.48%
648.*.js (New) 376.06kB 376.06kB 100.0% 🚀
709.*.css (New) 285.35kB 285.35kB 100.0% 🚀
core.*.css 11.28kB 12.31kB 1104.11% ⚠️
core.*.js 53 bytes 3.1kB 1.74%
355.*.js (Deleted) -446.4kB 0 bytes -100.0% 🗑️
847.*.css (Deleted) -330.13kB 0 bytes -100.0% 🗑️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong currency symbol when exporting invoices

2 participants