Skip to content

Conversation

@pierredup
Copy link
Member

Reduce the size of the logo on PDF files to prevent larger logo's from displaying over invoice text

Fixes #1965

@pierredup pierredup added this to the 2.3.9 milestone Oct 20, 2025
@pierredup pierredup self-assigned this Oct 20, 2025
@pierredup pierredup added the bug label Oct 20, 2025
@codecov
Copy link

codecov bot commented Oct 20, 2025

Bundle Report

Changes will decrease total bundle size by 408.77kB (-5.12%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
solidinvoice-webpack-bundle-array-push 7.57MB -408.77kB (-5.12%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: solidinvoice-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
app.*.css -555 bytes 1.36MB -0.04%
email.*.css -152.22kB 504.16kB -23.19%
pdf.*.css -152.22kB 445.21kB -25.48%
648.*.js (New) 376.06kB 376.06kB 100.0% 🚀
709.*.css (New) 285.35kB 285.35kB 100.0% 🚀
core.*.css 11.28kB 12.31kB 1104.11% ⚠️
core.*.js 53 bytes 3.1kB 1.74%
355.*.js (Deleted) -446.4kB 0 bytes -100.0% 🗑️
847.*.css (Deleted) -330.13kB 0 bytes -100.0% 🗑️

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.61%. Comparing base (1eb9311) to head (28833e2).
⚠️ Report is 5 commits behind head on 2.3.x.

Additional details and impacted files
@@             Coverage Diff              @@
##              2.3.x    #2006      +/-   ##
============================================
+ Coverage     48.49%   48.61%   +0.11%     
- Complexity     2749     2755       +6     
============================================
  Files           501      502       +1     
  Lines         10025    10047      +22     
============================================
+ Hits           4862     4884      +22     
  Misses         5163     5163              
Flag Coverage Δ
unittests 48.61% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pierredup pierredup merged commit 83ee874 into 2.3.x Oct 20, 2025
29 checks passed
@pierredup pierredup deleted the fix-pdf-logo-size branch October 20, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants