Skip to content

Update FormHandlerBundle for PHP 8.4 compatibility #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierredup merged 6 commits into from
Jun 3, 2025
Merged

Update FormHandlerBundle for PHP 8.4 compatibility #1760

pierredup merged 6 commits into from
Jun 3, 2025

Conversation

@pierredup
Copy link
Member

@pierredup pierredup commented Jun 1, 2025

No description provided.

@pierredup pierredup added this to the 2.3.7 milestone Jun 1, 2025
@pierredup pierredup self-assigned this Jun 1, 2025
@pierredup pierredup added the bug label Jun 1, 2025
@codecov
Copy link

codecov bot commented Jun 1, 2025

Bundle Report

Changes will decrease total bundle size by 408.3kB (-5.12%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
solidinvoice-webpack-bundle-array-push 7.57MB -408.3kB (-5.12%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: solidinvoice-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
app.*.css -555 bytes 1.36MB -0.04%
email.*.css -152.22kB 504.16kB -23.19%
pdf.*.css -152.22kB 445.21kB -25.48%
648.*.js (New) 376.53kB 376.53kB 100.0% 🚀
709.*.css (New) 285.35kB 285.35kB 100.0% 🚀
core.*.css 11.29kB 12.31kB 1104.5% ⚠️
core.*.js 53 bytes 3.1kB 1.74%
355.*.js (Deleted) -446.4kB 0 bytes -100.0% 🗑️
847.*.css (Deleted) -330.13kB 0 bytes -100.0% 🗑️

@codecov
Copy link

codecov bot commented Jun 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes missing coverage. Please review.

Project coverage is 48.32%. Comparing base (c309cfc) to head (96de964).
Report is 6 commits behind head on 2.3.x.

Files with missing lines Patch % Lines
src/InvoiceBundle/Repository/InvoiceRepository.php 0.00% 4 Missing ⚠️
src/CoreBundle/Twig/Extension/StatusExtension.php 77.77% 2 Missing ⚠️
src/ClientBundle/Repository/ClientRepository.php 0.00% 1 Missing ⚠️
src/CoreBundle/Entity/Version.php 0.00% 1 Missing ⚠️
src/CoreBundle/Form/FieldRenderer.php 0.00% 1 Missing ⚠️
src/CoreBundle/Logger/Dbal/TraceLogger.php 0.00% 1 Missing ⚠️
...eBundle/Routing/Loader/AbstractDirectoryLoader.php 0.00% 1 Missing ⚠️
src/CoreBundle/Routing/Loader/AjaxRouteLoader.php 0.00% 1 Missing ⚠️
src/CronBundle/Enum/ScheduleEndType.php 0.00% 1 Missing ⚠️
src/CronBundle/Enum/ScheduleRecurringType.php 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@             Coverage Diff              @@
##              2.3.x    #1760      +/-   ##
============================================
- Coverage     48.37%   48.32%   -0.05%     
  Complexity     2749     2749              
============================================
  Files           501      501              
  Lines          9939     9936       -3     
============================================
- Hits           4808     4802       -6     
- Misses         5131     5134       +3
Flag Coverage Δ
unittests 48.32% <48.71%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pierredup pierredup merged commit bc906ee into 2.3.x Jun 3, 2025
25 of 29 checks passed
@pierredup pierredup deleted the fix-php84 branch June 3, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pierredup pierredup

Labels

bug

Projects

None yet

Milestone

2.3.7

Development

Successfully merging this pull request may close these issues.

2 participants

@pierredup