Add SaaSBundle #1739
Merged
Add SaaSBundle #1739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates SaaS support into the SolidInvoice platform by:
- Replacing the old
CompanyFormHandlerwith a Symfony controller action (CreateCompany) - Extending
Companyto implementSubscribableInterfaceand adding acurrencyfield - Adding SaaS bundle configuration, routes, HTTP client setup, and adjusting PHP requirements to 8.3
Reviewed Changes
Copilot reviewed 61 out of 61 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CoreBundle/Form/Handler/CompanyFormHandler.php | Removed the old form handler in favor of a controller-based approach |
| src/CoreBundle/Entity/Company.php | Implemented SubscribableInterface, added currency property with validation |
| src/CoreBundle/Action/CreateCompany.php | New controller extending AbstractController to handle company creation |
| src/AppRequirements.php | Bumped PHP version requirement from 8.2 to 8.3 but left the version check incorrectly targeting 8.2 |
| config/routes/webhook.yaml | Added webhook routing for Lemon Squeezy |
| config/routes.php | Imported SaaS bundle routes under /billing |
| config/packages/saas/solidworx_saas.php | Configured SaaS subscription, payment, and Lemon Squeezy integration |
| config/packages/saas/http_client.php | Defined a scoped HTTP client for the Lemon Squeezy API |
| config/bundles.php | Loaded SaaS bundles conditionally based on environment |
| composer.json | Updated PHP platform requirement to 8.3 and added SaaS dependencies |
| README.md | Updated system requirements to PHP 8.3 |
| .github/workflows/unit-tests.yml | Extended CI matrix to include PHP 8.4 |
Comments suppressed due to low confidence (1)
src/AppRequirements.php:29
- The version check still enforces
PHP_VERSION_ID >= 80200even though the messages require 8.3.0. Update this toPHP_VERSION_ID >= 80300to match the new requirement.
PHP_VERSION_ID >= 80200,
Bundle ReportChanges will decrease total bundle size by 408.3kB (-5.12%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: solidinvoice-webpack-bundle-array-pushAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3.x #1739 +/- ##
============================================
- Coverage 49.47% 48.87% -0.61%
- Complexity 2694 2732 +38
============================================
Files 494 501 +7
Lines 9751 9875 +124
============================================
+ Hits 4824 4826 +2
- Misses 4927 5049 +122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.