Fix password reset process #1720
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the password reset process by integrating the symfonycasts/reset-password-bundle, refactoring related routes, controllers, entities, and configurations. Key changes include removing legacy confirmation token logic from the User entity and repository, introducing a dedicated ResetPasswordRequest entity and repository, and updating controllers and forms to support the new flow.
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| translations/messages.en.yml | Removed outdated password reset notes. |
| Resources/config/routing.php | Removed the legacy Send route and added a default token parameter for reset route. |
| Repository/UserRepository.php | Removed confirmation token clearing logic redundant with the new reset password flow. |
| Repository/ResetPasswordRequestRepository.php | Added repository implementation for handling reset password requests. |
| Form/Type/ResetPasswordRequestFormType.php & ChangePasswordFormType.php | Introduced new form types for reset password request and change password actions. |
| Entity/User.php & ResetPasswordRequest.php | Removed legacy confirmation token properties and added new entity for reset password requests. |
| Email/ResetPasswordEmail.php | Updated email subject and context to support reset token messaging. |
| Action/ForgotPassword/* | Refactored controllers for password reset, request, and check email flows; removed legacy Send action. |
| DataFixtures/ORM/LoadData.php | Updated fixtures to remove legacy password request data. |
| Migrations/Version20306.php | Created a migration to drop obsolete columns and create the new reset_password_request table. |
| Config files (security.php, reset_password.php, bundles.php, composer.json) | Updated configuration to support the new reset password bundle and its routing/security requirements. |
Bundle ReportChanges will decrease total bundle size by 407.05kB (-5.1%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: solidinvoice-webpack-bundle-array-pushAssets Changed:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3.x #1720 +/- ##
============================================
+ Coverage 48.74% 49.47% +0.72%
- Complexity 2683 2694 +11
============================================
Files 491 494 +3
Lines 9648 9751 +103
============================================
+ Hits 4703 4824 +121
+ Misses 4945 4927 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The password reset feature currently doesn't work. Here we use the
symfonycasts/reset-password-bundlepackage to add a better and proper password reset flow.