Skip to content

Improve workflow buttons #1672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pierredup merged 3 commits into from
May 4, 2025
Merged

Improve workflow buttons #1672

pierredup merged 3 commits into from
May 4, 2025

Conversation

@pierredup
Copy link
Member

@pierredup pierredup commented May 4, 2025

  • When editing an invoice/quote, we were showing way too many buttons (E.G Save as draft doesn't make sense when editing a pending invoice)
  • Recurring invoices had buttons that were invalid (E.G Save and Send is not valid for recurring invoices).
  • Draft recurring invoices could not be activated. Added a workflow button when viewing a recurring invoice to activate it
  • Remove recurring info for draft recurring invoices (since it won't recur, so the info is only useful for active recurring invoices)

@pierredup pierredup added the bug label May 4, 2025
@pierredup pierredup added this to the 2.3.5 milestone May 4, 2025
@pierredup pierredup self-assigned this May 4, 2025
@codecov
Copy link

codecov bot commented May 4, 2025

Bundle Report

Changes will decrease total bundle size by 407.05kB (-5.1%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
solidinvoice-webpack-bundle-array-push 7.57MB -407.05kB (-5.1%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: solidinvoice-webpack-bundle-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
app.*.css -555 bytes 1.36MB -0.04%
email.*.css -152.22kB 504.16kB -23.19%
pdf.*.css -152.22kB 445.21kB -25.48%
648.*.js (New) 376.53kB 376.53kB 100.0% 🚀
145.*.css (New) 297.58kB 297.58kB 100.0% 🚀
runtime.*.js -1 bytes 3.21kB -0.03%
core.*.js 53 bytes 3.1kB 1.74%
core.*.css 311 bytes 1.33kB 30.43% ⚠️
355.*.js (Deleted) -446.4kB 0 bytes -100.0% 🗑️
847.*.css (Deleted) -330.13kB 0 bytes -100.0% 🗑️

@codecov
Copy link

codecov bot commented May 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.74%. Comparing base (cec438b) to head (393d200).
Report is 3 commits behind head on 2.3.x.

Additional details and impacted files 
@@            Coverage Diff            @@
##              2.3.x    #1672   +/-   ##
=========================================
  Coverage     48.74%   48.74%           
  Complexity     2683     2683           
=========================================
  Files           491      491           
  Lines          9648     9648           
=========================================
  Hits           4703     4703           
  Misses         4945     4945
Flag Coverage Δ
unittests 48.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pierredup pierredup merged commit 066ae17 into 2.3.x May 4, 2025
40 of 42 checks passed
@pierredup pierredup deleted the improve-workflow branch May 4, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pierredup pierredup

Labels

bug

Projects

None yet

Milestone

2.3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@pierredup