Skip to content

Update patch to fix libuiohook hanging on Mac#37

Closed
hsource wants to merge 1 commit into
SnosMe:masterfrom
hsource:harry-patch-mac
Closed

Update patch to fix libuiohook hanging on Mac#37
hsource wants to merge 1 commit into
SnosMe:masterfrom
hsource:harry-patch-mac

Conversation

@hsource

@hsource hsource commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

Motivation/Fix

awakened-poe-trade on Mac would hang after running a while. I debugged it and submitted a PR to libuiohook, which has more details:

kwhat/libuiohook#184

This PR just includes that change as a patch.

Alternatively, we can also wait for libuiohook to merge in the PR and then just update the version.

Testing

# Build the branch
git clone git@github.com:hsource/uiohook-napi.git --recursive
cd uiohook-napi
git checkout harry-patch-mac
yarn install
yarn apply-libuiohook-patch
yarn prebuild

# Install in awakened-poe-trade
git clone git@github.com:SnosMe/awakened-poe-trade.git
cd awakened-poe-trade/renderer
yarn install
yarn make-index-files
yarn build
cd ../main
yarn install
yarn remove uiohook-napi && yarn add ../../uiohook-napi
yarn build
yarn package

I then used it until I got the "CGEventTap timeout" error and verified events still worked after that

@maneetgoyal

maneetgoyal commented Jan 22, 2024

Copy link
Copy Markdown

@hsource Is this PR still needed given kwhat/libuiohook#184 is merged? uiohook-napi is also released https://www.npmjs.com/package/uiohook-napi/v/1.5.3 it seems.

Can you please suggest if your new fix addresses #24 too?

@hsource hsource closed this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants