Skip to content

Conversation

@msotheeswaran-sc
Copy link
Collaborator

Fixes #601.

@JohnSully
Copy link
Collaborator

Background:

Redis includes the replication buffer size but not the client output buffers of the replicas. When KeyDB began using the replication buffer as the client output buffer and eliminated the extra copy we now have diverging behavior with Redis.

The fix here is to include the base replication buffer size towards maxmem but exclude any extra dynamic growth which occurs when we are emulating the expanding client output buffer behavior. This gets us back to parity with Redis' memory trackingl.

@msotheeswaran-sc msotheeswaran-sc merged commit 1735e73 into main Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] used_memory exceeds maxmemory

3 participants