Implement start_interactive_move.#174
Merged
elinorbgr merged 2 commits intoSmithay:masterfrom Jan 27, 2021
daxpedda:start-interactive-move
Merged
Implement start_interactive_move.#174elinorbgr merged 2 commits intoSmithay:masterfrom daxpedda:start-interactive-move
start_interactive_move.#174elinorbgr merged 2 commits intoSmithay:masterfrom
daxpedda:start-interactive-move
Conversation
8 tasks
Member
|
Thanks, that looks good! I think we can remove the last paragraph of the doc-comment, which does not add much for users of SCTK. And could you please also add an entry in the "unreleased" section of the changelog for this? |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in chat.
I have copied the documentation from the wayland-protocols specification, as I have basically very little clue about Wayland I'm open to suggestions, thank you.
I will leave it as a draft until I try it out, which I'm in the process of doing at the moment.Tested with rust-windowing/winit#1840, works like a charm.