Skip to content

Go 1.26.1#98

Merged
az-smartling merged 4 commits into
masterfrom
go_1_26_1
Apr 10, 2026
Merged

Go 1.26.1#98
az-smartling merged 4 commits into
masterfrom
go_1_26_1

Conversation

@az-smartling

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project to Go 1.26.1, replaces interface{} with any, and adopts modern Go features like t.Context() and strings.SplitSeq. It also updates YAML tags to use omitzero. However, a critical syntax error was introduced in the machine translation services where pointer.NewP(value) was incorrectly replaced with new(value), which will cause compilation failures because the new built-in function requires a type argument rather than a value.

Comment thread services/mt/run_detect.go
Comment thread services/mt/run_translate.go
@az-smartling az-smartling requested a review from dimitrystd April 6, 2026 09:06
@az-smartling az-smartling merged commit 1b722fc into master Apr 10, 2026
@az-smartling az-smartling deleted the go_1_26_1 branch April 10, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants