Skip to content

FileDownload change includeOriginalStrings to pointer#97

Merged
az-smartling merged 1 commit into
masterfrom
FileDownload-includeOriginalStrings_to_pointer
Jan 29, 2026
Merged

FileDownload change includeOriginalStrings to pointer#97
az-smartling merged 1 commit into
masterfrom
FileDownload-includeOriginalStrings_to_pointer

Conversation

@az-smartling

Copy link
Copy Markdown
Contributor

FileDownload: changed includeOriginalStrings to pointer.
Upgraded golang.org/x/* packages

Smartling/api-sdk-go#25

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @az-smartling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on maintaining the project's dependencies by upgrading the Smartling/api-sdk-go and several core golang.org/x packages. The API SDK update specifically addresses a change in the FileDownload functionality, where the includeOriginalStrings parameter is now handled as a pointer. Additionally, minor code hygiene improvements were applied to an initialization command file.

Highlights

  • API SDK Update: The github.com/Smartling/api-sdk-go dependency has been updated to a newer version. This update is noted to include a change where the includeOriginalStrings parameter in FileDownload operations is now handled as a pointer type.
  • Go Standard Library Package Upgrades: Several golang.org/x/* packages, including sync, crypto, sys, term, and text, have been upgraded to their latest versions, ensuring the project benefits from the latest features and security patches.
  • Code Style and Import Refinement: Minor adjustments were made in cmd/init/cmd_init.go to improve import clarity by aliasing the services/init package to initialize and to standardize a variable declaration from a block to a single line.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@az-smartling az-smartling merged commit a0b2a9c into master Jan 29, 2026
@az-smartling az-smartling deleted the FileDownload-includeOriginalStrings_to_pointer branch January 29, 2026 13:01

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily upgrades several dependencies, including github.com/Smartling/api-sdk-go and various golang.org/x/* packages. It also includes a small but necessary fix in cmd/init/cmd_init.go to resolve a package name collision with the Go keyword init. My review includes a suggestion to further improve the package naming in that file for better code clarity and maintainability.

Comment thread cmd/init/cmd_init.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant