CON-1843 all option for download command#93
Conversation
Summary of ChangesHello @az-smartling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces an --all option to the pull command for downloading all files and makes it mandatory to specify either a URI or the --all flag. The changes are logical and include updates to the command definition, parameter validation, and tests. My review focuses on simplifying the validation logic for the new flag to make it less confusing and to avoid potential bugs. Additionally, I've suggested expanding the tests for the new functionality to cover the primary use case of the --all flag and its interaction with other parameters.
| if p.All && p.URI != "" && p.URI != "." && p.URI != "**" { | ||
| return clierror.ErrConflictingParams([]string{"uri", "all"}) | ||
| } |
There was a problem hiding this comment.
The validation logic for conflicting uri and --all parameters is unnecessarily complex and allows for confusing combinations. Specifically, allowing uri to be . or ** when --all is also specified is redundant. The case for . is also likely a bug, as it would cause the glob pattern to match only a file literally named . instead of all files. A simpler approach would be to disallow any uri argument when --all is used.
| if p.All && p.URI != "" && p.URI != "." && p.URI != "**" { | |
| return clierror.ErrConflictingParams([]string{"uri", "all"}) | |
| } | |
| if p.All && p.URI != "" { | |
| return clierror.ErrConflictingParams([]string{"uri", "all"}) | |
| } |
Co-authored-by: Dmitry Studynsky <dimitrystd@users.noreply.github.com>
Added
--alloption to download all file.Removed possibility to download files without
--alloruri.Added tests.