CON-1837 Return information about job#89
Conversation
Summary of ChangesHello @az-smartling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user feedback provided after a file push operation by displaying comprehensive information about the associated Smartling job. It ensures that users can quickly access the job's unique identifier, its human-readable name, and a direct link to its page within the Smartling dashboard, streamlining the workflow for tracking translation jobs. This enhancement is supported by an update to the Smartling API SDK and new logic for retrieving and presenting job details. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the push command by displaying the Smartling job's UID, name, and URL after execution. This is a helpful addition for users. The implementation correctly handles cases for both creating a new job and using an existing one. My review includes a suggestion to improve the maintainability and readability of the new getJobURL function by using string formatting, which is more idiomatic in Go.
| pattern := `^[a-z0-9]{12}$` | ||
| var jobUID string | ||
| if re := regexp.MustCompile(pattern); params.JobIDOrName != "" && re.MatchString(params.JobIDOrName) { | ||
| jobUID = params.JobIDOrName | ||
| } |
There was a problem hiding this comment.
Since we added the GetJob API, we can finally remove this hack (guessing if it is a real UID).
The new flow can be:
- We can keep this regex to validate UID
- GetJob(projectID, jobUID)
- If it returned the job without the error, then use jobUID and received jobName
- Otherwise, create a new job.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Return information about job
Smartling/api-sdk-go#19