Override file type#87
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @az-smartling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces the capability to explicitly override the file type during file push and machine translation operations within the Smartling CLI. It also includes an update to the CLI's version, a significant upgrade of the underlying Smartling API SDK, and general dependency management improvements.
Highlights
- File Type Override: Added functionality to specify and override the file type for both file push and machine translation processes, providing greater control over how files are handled.
- CLI Version Update: The Smartling CLI version has been incremented from 2.3 to 2.4.1.
- API SDK Upgrade: The
api-sdk-godependency has been updated to a newer version, bringing potential new features or bug fixes from the SDK. - Code Refactoring & Cleanup: Import aliases for API packages have been standardized, and an unused
google/uuiddependency has been removed, along with updates to other Go module checksums.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to override the file type for push and translate commands, which is a useful feature. The changes include updating the Smartling Go SDK, bumping the CLI version, and implementing the file type override logic. The code is generally well-structured. I've found a couple of minor issues in the new logic with incorrect log messages and have suggested refactoring for better clarity and correctness. Otherwise, the changes look good.
# Conflicts: # cmd/cmd_root.go # go.mod # go.sum # services/files/run_push.go # services/mt/run_translate.go
Override file type.