Reduce binary size with build flags#102
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Go build command in the Makefile to include CGO_ENABLED=0, -trimpath, and -ldflags="-s -w" for optimized and reproducible builds. Feedback suggests extracting these hardcoded flags into variables to improve maintainability and allow for easier local debugging, as well as injecting version information into the binary using linker flags.
dimitrystd
approved these changes
May 15, 2026
dimitrystd
left a comment
Contributor
There was a problem hiding this comment.
I was lazy to read docs about these flags. I hope we will get developer-friendly stack traces from the clients (in case of error).
Contributor
Author
|
For everyday error stack traces - yes, they'll be readable. For attaching a debugger or profiling a production binary — no, that requires overriding LDFLAGS at build time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-trimpath -ldflags="-s -w"andCGO_ENABLED=0to the cross-platform build rule in the Makefile