RPS-10045 Download job files#31
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the ListFiles method to the Job interface, enabling paginated retrieval of source files associated with a translation job. It also enhances GetJobResponse by adding TargetLocaleIDs and standardizes parameter naming by replacing translationJobUID with jobUID. Feedback was provided to optimize performance in ListFiles by pre-allocating the results slice based on the total item count returned by the API.
dimitrystd
reviewed
May 15, 2026
dimitrystd
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download job files
Smartling/smartling-cli#101