Skip to content

CON-1870 Logging Message For No File Downloaded#23

Merged
az-smartling merged 2 commits into
masterfrom
CON-1870_Logging_Message_For_No_File_Downloaded
Nov 21, 2025
Merged

CON-1870 Logging Message For No File Downloaded#23
az-smartling merged 2 commits into
masterfrom
CON-1870_Logging_Message_For_No_File_Downloaded

Conversation

@az-smartling

@az-smartling az-smartling commented Nov 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Implemented ProgressPercent calculation for structure FileStatusTranslation
Smartling/smartling-cli#94

@gemini-code-assist

gemini-code-assist Bot commented Nov 20, 2025

Copy link
Copy Markdown

Summary of Changes

Hello @az-smartling, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new utility method, ProgressPercent, within the FileStatusTranslation structure. This method provides a calculated percentage representing the completion status of strings, considering both completed and authorized strings. The addition is accompanied by a thorough suite of unit tests to ensure its accuracy and robustness across different scenarios, enhancing the reliability of progress tracking.

Highlights

  • New Progress Calculation Method: A new method, ProgressPercent(), has been added to the FileStatusTranslation struct to calculate the completion percentage of strings.
  • Percentage Logic: The ProgressPercent() method calculates the percentage based on CompletedStringCount relative to the sum of CompletedStringCount and AuthorizedStringCount, handling division by zero by returning 0.
  • Comprehensive Unit Tests: A new test file, file_status_translation_test.go, has been introduced with extensive unit tests for the ProgressPercent() method, covering various scenarios including edge cases, zero totals, and different percentage values.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 20, 2025
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a ProgressPercent method on the FileStatusTranslation struct to calculate the completion percentage, along with corresponding unit tests. The implementation is sound, but could be improved for efficiency by using integer arithmetic instead of floating-point conversions. The new tests are comprehensive, but have minor issues with clarity: one test case is missing an explicit expected value, and another has a misleading name regarding rounding. I've provided suggestions to address these points to improve code performance and test maintainability.

Comment thread helpers/sm_file/file_status_translation.go Outdated
Comment thread helpers/sm_file/file_status_translation_test.go
Comment thread helpers/sm_file/file_status_translation_test.go Outdated
@az-smartling az-smartling mentioned this pull request Nov 20, 2025
Merged
dimitrystd
dimitrystd requested changes Nov 20, 2025
View reviewed changes
Comment thread helpers/sm_file/file_status_translation_test.go
@az-smartling az-smartling changed the title CON-1870_Logging_Message_For_No_File_Downloaded CON-1870 Logging Message For No File Downloaded Nov 21, 2025
@az-smartling az-smartling merged commit 1b9af60 into master Nov 21, 2025
@az-smartling az-smartling deleted the CON-1870_Logging_Message_For_No_File_Downloaded branch November 21, 2025 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimitrystd dimitrystd dimitrystd approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@az-smartling @dimitrystd