Optimizations for Paper (cargo network optimizations)#2106
Merged
TheBusyBiscuit merged 10 commits intomasterfrom Jul 21, 2020
Merged
Optimizations for Paper (cargo network optimizations)#2106TheBusyBiscuit merged 10 commits intomasterfrom
TheBusyBiscuit merged 10 commits intomasterfrom
Conversation
WalshyDev
previously approved these changes
Jul 20, 2020
Member
WalshyDev
left a comment
There was a problem hiding this comment.
Looking good. PaperLib is a nice thing to add. We should be making a paper tag on the server too when this PR is merged.
src/main/java/io/github/thebusybiscuit/slimefun4/core/commands/subcommands/VersionsCommand.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/gps/ElevatorPlate.java
Outdated
Show resolved
Hide resolved
WalshyDev
requested changes
Jul 20, 2020
src/main/java/io/github/thebusybiscuit/slimefun4/api/gps/TeleportationManager.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/thebusybiscuit/slimefun4/implementation/items/gps/ElevatorPlate.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Ready to be merged? @WalshyDev I tested it on Spigot and Paper again, no issues thus far. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces a bunch of optimizations for Servers using Paper.
Paper uses Asynchronous Chunk Generation/Loading which can improve performance for long-distance teleports.
BlockState Snapshots
Normally, Spigot creates a new BlockState instance as a hard copy, for InventoryHolders the Inventory is only copied softly, as a reference. Since Inventories are already Thread-safe and only the reference is passed, cargo networks have no reason to create a BlockState snapshot.
This behaviour cannot be avoided when using Spigot, with Paper it can.
So this will improve performance drastically (Sometimes up to 6 times smoother from what i tested) and optimize Cargo networks to work best when using Paper.
Changes
Checklist