[Backport] ReadPixels: Check for errors only when VTK is configured to report errors

jspanchu · jcfr · commit b4fa8ba5d221 · 2023-12-17T14:13:44.000-05:00
Merge-request: vtk/vtk!10646 (cherry picked from commit Kitware/VTK@3bd2e83)
diff --git a/Rendering/OpenGL2/vtkOpenGLRenderWindow.cxx b/Rendering/OpenGL2/vtkOpenGLRenderWindow.cxx
@@ -1080,9 +1080,11 @@ int vtkOpenGLRenderWindow::ReadPixels(
   }
 
   // Must clear previous errors first.
+#if VTK_REPORT_OPENGL_ERRORS
   while (glGetError() != GL_NO_ERROR)
   {
   }
+#endif
 
   this->GetState()->vtkglDisable(GL_SCISSOR_TEST);
 

Original file line number	Diff line number	Diff line change
`@@ -1080,9 +1080,11 @@ int vtkOpenGLRenderWindow::ReadPixels(`
`1080`	`1080`	`}`
`1081`	`1081`
`1082`	`1082`	`// Must clear previous errors first.`
	`1083`	`+#if VTK_REPORT_OPENGL_ERRORS`
`1083`	`1084`	`while (glGetError() != GL_NO_ERROR)`
`1084`	`1085`	`{`
`1085`	`1086`	`}`
	`1087`	`+#endif`
`1086`	`1088`
`1087`	`1089`	`this->GetState()->vtkglDisable(GL_SCISSOR_TEST);`
`1088`	`1090`