ENH: Vendor SharedForward which was removed from KWSys #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sample failure output: 2: Test command: C:\Misc\SlicerExecutionModel\bld22\ModuleDescriptionParser\bin\Debug\Parser1Test.exe "C:/Misc/SlicerExecutionModel/ModuleDescriptionParser/Testing/TestData/ParserTest2.xml" 2: Working Directory: C:/Misc/SlicerExecutionModel/bld22/ModuleDescriptionParser/Testing 2: Test timeout computed to be: 1500 2: not well-formed (invalid token) at line 111 1/2 Test #2: Parser1Test2 .....................***Failed 0.02 sec
Member
Author
|
The CI seems to be broken. The tests succeed on both my local Linux and Windows machines. Should we merge this, or wait for someone to fix the CI and rebase? |
aylward
approved these changes
May 30, 2024
Member
There was a problem hiding this comment.
Nice!
Failing test seems to be an authentication issue (requesting write access to this repo during testing - weird). I've tested this on my laptop: Windows and Linux. Works great on my custom (non-Slicer) apps that use SlicerExecutionModel for CLI parsing.
3 tasks
Member
|
@dzenanz THANK YOU! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #138.