COMP: Prefer clearing CMAKE_INSTALL_NAME_TOOL on a per-project basis#7540
Merged
jcfr merged 1 commit intoSlicer:mainfrom Jan 12, 2024
Merged
Conversation
Follow-up of 52b238d (COMP: Ensure full path ID for macOS libraries installed for fix-up) reverting the systematic clearing of CMAKE_INSTALL_NAME_TOOL. Due to the possibility of external projects (e.g., LibFFI) enabling languages (e.g., ASM) that necessitate `install_name_tool` via the "CMakeFindBinUtils" module, we opt to clear CMAKE_INSTALL_NAME_TOOL on a per-project basis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of 52b238d (
COMP: Ensure full path ID for macOS libraries installed for fix-up) reverting the systematic clearing ofCMAKE_INSTALL_NAME_TOOL.Due to the possibility of external projects (e.g., LibFFI) enabling languages (e.g., ASM) that necessitate
install_name_toolvia the "CMakeFindBinUtils" module, we opt to clearCMAKE_INSTALL_NAME_TOOLon a per-project basis.Related: