ENH: Update VTK backporting VR and OpenXR improvements#7516
Merged
jcfr merged 1 commit intoSlicer:mainfrom Dec 30, 2023
Merged
Conversation
Updates VTK to support integration of the OpenXR runtime into the SlicerVirtualReality extension. The following merge requests, including the backported commits referenced below, have been submitted to upstream VTK for reference * `VR: Declare AddAction() functions as virtual` See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10785 * `VR: Resolve "Not rendered" warnings after XR RenderWindow Initialization` See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10794 Additionally this commit also adds the OpenXR bindings for the oculus touch controller copied from Kitware/ParaView@ec4111e7c. See `Plugins/XRInterface/Plugin/pv_openxr_binding_oculus_touch_controller.json`. List of VTK changes: ``` $ git shortlog 2f050efc8..b9aae674d --no-merges Jean-Christophe Fillion-Robin (5): Revert "[Backport MR-10785] VR: Declare AddAction() functions as virtual" [Backport MR-10785] VR: Improve consistency in OpenVR interactor AddAction() [Backport MR-10785] VR: Declare AddAction() functions as virtual [Backport MR-10794] VR: Resolve "Not rendered" warnings after XR RenderWindow Initialization [SlicerVirtualReality] ENH: Add OpenXR bindings for oculus_touch ```
1cc6ea2 to
91ad9f0
Compare
Member
Author
|
The changes have been tested locally ✅ |
This was referenced Dec 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates VTK to support integration of the OpenXR runtime into the SlicerVirtualReality extension.
The following merge requests, including the backported commits referenced below, have been submitted to upstream VTK for reference
VR: Declare AddAction() functions as virtualSee https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10785VR: Resolve "Not rendered" warnings after XR RenderWindow InitializationSee https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10794Additionally this commit also adds the OpenXR bindings for the oculus touch controller copied from Kitware/ParaView@ec4111e7c. See
Plugins/XRInterface/Plugin/pv_openxr_binding_oculus_touch_controller.json.List of VTK changes: