ENH: Update VTK to backporting VR, OpenVR and OpenXR improvements#7514
Merged
jcfr merged 1 commit intoSlicer:mainfrom Dec 28, 2023
Merged
ENH: Update VTK to backporting VR, OpenVR and OpenXR improvements#7514jcfr merged 1 commit intoSlicer:mainfrom
jcfr merged 1 commit intoSlicer:mainfrom
Conversation
Updates VTK to support the integration of multiple runtime into the SlicerVirtualReality extension. The following merge requests, including the backported commits referenced below, have been submitted to upstream VTK for reference * VR: Update interactor style API adding GetMappedAction(). See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10784 * VR: Declare AddAction() functions as virtual. See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10785 * VR: Update vtkVRRenderWindowInteractor marking ComplexGesture recognition functions as public. See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10786 * VR: Add SetInteractionState() API to VR interactor style. See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10789 List of VTK changes: ``` $ git shortlog 573f18292..2f050efc8 --no-merges Jean-Christophe Fillion-Robin (11): [Backport MR-10784] VR: Update interactor style API adding GetMappedAction() [Backport MR-10785] VR: Declare AddAction() functions as virtual [Backport MR-10786] VR: Mark ComplexGesture recognition functions as public [Backport MR-10786] VR: Add GetCurrentGesture() API for retrieving the gesture being recognized [Backport MR-10786] VR: Add SetCurrentGesture() API for setting the gesture being recognized [Backport MR-10786] VR: Add GetDeviceInputDownCount() API [Backport MR-10786] VR: Add SetDeviceInputDownCount() API [Backport MR-10786] VR: Add SetStartingPhysicalToWorldMatrix() API [Backport MR-10786] VR: Add SetStartingPhysicalEventPose() API [Backport MR-10789] VR: Add SetInteractionState() API to VR interactor style [Backport MR-10789] VR: Improve robustness of GetInteractionState() by checking input ```
Member
Author
|
The changes have been tested locally ✅ |
This was referenced Dec 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates VTK to support the integration of multiple runtime into the SlicerVirtualReality extension.
The following merge requests, including the backported commits referenced below, have been submitted to upstream VTK for reference
VR: Update interactor style API adding GetMappedAction().See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10784
VR: Declare AddAction() functions as virtual.See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10785
VR: Update vtkVRRenderWindowInteractor marking ComplexGesture recognition functions as public.See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10786
VR: Add SetInteractionState() API to VR interactor style.See https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10789
List of VTK changes: