BUG: Update VTK backporting fix for OpenVR gesture recognition#7503
Merged
jcfr merged 1 commit intoSlicer:mainfrom Dec 22, 2023
Merged
BUG: Update VTK backporting fix for OpenVR gesture recognition#7503jcfr merged 1 commit intoSlicer:mainfrom
jcfr merged 1 commit intoSlicer:mainfrom
Conversation
This includes a workaround to recognize OpenVR gesture where buttons are pressed consecutively. Corresponding changes have been contributed to upstream VTK as MR-10771 [1] and MR-10778 [2] [1] https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10771 [2] https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10778 List of VTK changes: $ git shortlog d5d688b47..08161371c2 --no-merges Jean-Christophe Fillion-Robin (2): [Backport MR-10771] BUG: Add missing Elevation3DEvent to vtkCommand::EventHasData() [Backport MR-10778] BUG: Recognize OpenVR gesture where buttons are pressed consecutively
95163b1 to
8e12844
Compare
Member
Author
|
Branch has been locally built on the our three build machine without issue ✅ Since the key changes impact the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes a workaround to recognize OpenVR gesture where buttons are pressed consecutively.
Corresponding changes have been contributed to upstream VTK as MR-10771 and MR-10778
List of VTK changes: