BUG: Restore maximization of view on double click event#7442
Merged
jcfr merged 3 commits intoSlicer:mainfrom Dec 4, 2023
Merged
BUG: Restore maximization of view on double click event#7442jcfr merged 3 commits intoSlicer:mainfrom
jcfr merged 3 commits intoSlicer:mainfrom
Conversation
This commit fixes a regression introduced in 1cc3b2c (ENH: Improve Event Delegation in qMRMLThreeDView and qMRMLSliceView) adding missing observers.
…/pan This commit fixes a regression introduced in 1cc3b2c (ENH: Improve Event Delegation in qMRMLThreeDView and qMRMLSliceView) adding missing observers.
a7c2cb5 to
8c5c03c
Compare
Contributor
|
Thank you, I can confirm confirm that this also fixes touchscreen interactions on Windows that got broken as well. |
Contributor
|
@jcfr would it be possible to create a 5.6.1 patch release within a few days? |
This was referenced Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes a regression introduced in 1cc3b2c (
ENH: Improve Event Delegation in qMRMLThreeDView and qMRMLSliceView) adding missing observers.