ENH: Set MRML interactor style camera node observing displayable manager#7324
Merged
jcfr merged 1 commit intoSlicer:mainfrom Nov 2, 2023
Merged
Conversation
lassoan
reviewed
Oct 30, 2023
Contributor
lassoan
left a comment
There was a problem hiding this comment.
This looks good to me. It is a somewhat more complex design but conceptually more clear. Just added some nitpicks inline.
Libs/MRML/DisplayableManager/vtkMRMLThreeDViewInteractorStyle.cxx
Outdated
Show resolved
Hide resolved
Libs/MRML/DisplayableManager/vtkMRMLThreeDViewInteractorStyle.cxx
Outdated
Show resolved
Hide resolved
73a9ade to
c3ed96e
Compare
Member
Author
|
@lassoan I addressed your comment and also created an issue to document possible path forward to improve how we associated view and camera node: |
Member
Author
|
Waiting the following pull request is integrated, I cancelled the Without it the |
c3ed96e to
73532a3
Compare
lassoan
approved these changes
Nov 2, 2023
Contributor
lassoan
left a comment
There was a problem hiding this comment.
It looks good to me, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.