Skip to content

ENH: Simplify vtkMRMLViewInteractorStyle::SetMouseCursor#7323

Merged
jcfr merged 1 commit intoSlicer:mainfrom
jcfr:simplify-vtkMRMLViewInteractorStyle-SetMouseCursor
Oct 30, 2023
Merged

ENH: Simplify vtkMRMLViewInteractorStyle::SetMouseCursor#7323
jcfr merged 1 commit intoSlicer:mainfrom
jcfr:simplify-vtkMRMLViewInteractorStyle-SetMouseCursor

Conversation

@jcfr
Copy link
Member

@jcfr jcfr commented Oct 30, 2023

Instead of relying on the "CurrentRenderer" indirectly set by "vtkInteractorStyle::FindPokedRenderer", directly retrieve the render window from the interactor.

Instead of relying on the "CurrentRenderer" indirectly set by
"vtkInteractorStyle::FindPokedRenderer", directly retrieve the
render window from the interactor.
Copy link
Contributor

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jcfr jcfr merged commit 7dcdda6 into Slicer:main Oct 30, 2023
@jcfr jcfr deleted the simplify-vtkMRMLViewInteractorStyle-SetMouseCursor branch October 30, 2023 20:09
@jcfr jcfr added the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Nov 5, 2023
@jcfr jcfr removed the backport:5.x Identify pull request expected to be backported to the current 5.x release branch. label Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants