Remove obsolete OnInteractorStyleEvent#7320
Merged
jcfr merged 2 commits intoSlicer:mainfrom Oct 30, 2023
Merged
Conversation
Following changes introduced in abff04f (ENH: Reimplement volume rendering displayable manager), the event handling mechanisms was restructured. As a result, the invocation of "UpdatePipelineTransforms()" within the "OnInteractorStyleEvent" function became obsolete. Furthermore, note that the call to the "OnInteractorStyleEvent" function stopped working following the alterations made in a0ad2a3 (ENH: Handle 3D events in MRML interactor style and markups VTK widgets). This change removed the installation of the interactor style observer from "SetAndObserveInteractorStyle()".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following changes introduced in abff04f (
ENH: Reimplement volume rendering displayable manager), the event handling mechanisms was restructured. As a result, the invocation of "UpdatePipelineTransforms()" within the "OnInteractorStyleEvent" function became obsolete.Furthermore, note that the call to the "OnInteractorStyleEvent" function stopped working following the alterations made in a0ad2a3 (
ENH: Handle 3D events in MRML interactor style and markups VTK widgets). This change removed the installation of the interactor style observer from "SetAndObserveInteractorStyle()".Also removes empty
vtkMRMLMarkupsDisplayableManager::OnInteractorStyleEvent()function.