ENH: Remove unused API to set/get displayable manager interactor abort flags#7319
Merged
jcfr merged 1 commit intoSlicer:mainfrom Oct 30, 2023
Merged
Conversation
…t flags The InteractorStyleAbort API was originally introduced in 8ded9a0 (ENH: eliminated conflict between crosshair navigation and window level). Then, it was superseded by the InteractorAbort API in 0b9b339 (BUG: Slicer#2629. Window level controls conflicted with crosshair navigation) Ultimately, the last uses of either the InteractorStyleAbort or InteractorAbort API were removed in dc2c095 (ENH: Improved crosshair usability, added display in 3D view)
lassoan
approved these changes
Oct 30, 2023
Contributor
lassoan
left a comment
There was a problem hiding this comment.
Looks good to me. These are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
InteractorStyleAbortAPI was originally introduced in 8ded9a0 (ENH: eliminated conflict between crosshair navigation and window level).Then, it was superseded by the
InteractorAbortAPI in 0b9b339 (BUG: #2629. Window level controls conflicted with crosshair navigation)Ultimately, the last uses of either the
InteractorStyleAbortorInteractorAbortAPI were removed in dc2c095 (ENH: Improved crosshair usability, added display in 3D view)