COMP: Update CTK to include build-system fixes#7318
Merged
jcfr merged 1 commit intoSlicer:mainfrom Oct 30, 2023
Merged
Conversation
See commontk/CTK@b9ef9b8...4888deb List of CTK changes: $ git shortlog b9ef9b8aa..4888deb1d --no-merges Jean-Christophe Fillion-Robin (4): COMP: Fix CTK PluginFramework library build COMP: Fix configuration without explicitly setting CTK_QT_VERSION COMP: Fix CMake 3.26 warning in ctkLinkerAsNeededFlagCheck project COMP: Add install rules for PluginFramework CMake modules
pieper
approved these changes
Oct 30, 2023
Member
pieper
left a comment
There was a problem hiding this comment.
I didn't try building it but it looks fine to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See commontk/CTK@b9ef9b8...4888deb
List of CTK changes: