ENH: Update qMRMLThreeDView to retrieve camera node from displayable manager#7316
Merged
jcfr merged 2 commits intoSlicer:mainfrom Oct 30, 2023
Merged
Conversation
Follow-up 1144f81 (ENH: Refactor visibility of displayable nodes in hierarchies) where the vtkMRMLThreeDViewInteractorStyle class friendship was introduced but not used. It turns out the displayable manager base class provides the RequestRender() function.
lassoan
approved these changes
Oct 30, 2023
Contributor
lassoan
left a comment
There was a problem hiding this comment.
The changes look good to me, but it would be even better to deprecate these methods, They should not be at this level. Why are they here (in the widget) instead of logic classes? If they are not used anywhere (Slicer core, CTK,..) then we should deprecate them and remove in a few years.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.