Skip to content

COMP: Fix inner project config removing invalid CMake statement#6419

Merged
jcfr merged 1 commit intoSlicer:masterfrom
jcfr:fix-cmake-regression-introduced-removing-vtk8-support
Jun 8, 2022
Merged

COMP: Fix inner project config removing invalid CMake statement#6419
jcfr merged 1 commit intoSlicer:masterfrom
jcfr:fix-cmake-regression-introduced-removing-vtk8-support

Conversation

@jcfr
Copy link
Member

@jcfr jcfr commented Jun 8, 2022

This commit updates "SlicerBlockInstallExternalPythonModules"
CMake module fixing the following regression introduced
in b9ac6ed (COMP: Remove support for VTK8)

  CMake Error at CMake/SlicerBlockInstallExternalPythonModules.cmake:16 (endif):
    Flow control statements are not properly nested.
  Call Stack (most recent call first):
    CMake/SlicerCPack.cmake:172 (include)
    CMake/LastConfigureStep/CMakeLists.txt:44 (include)

@jcfr jcfr force-pushed the fix-cmake-regression-introduced-removing-vtk8-support branch from 59e9995 to feeff23 Compare June 8, 2022 17:57
@jcfr jcfr changed the title COMP: Fix macOS packaging removing invalid "endif" CMake statement COMP: Fix inner project config removing invalid CMake statement Jun 8, 2022
This commit updates "SlicerBlockInstallExternalPythonModules"
CMake module fixing the following regression introduced
in b9ac6ed (COMP: Remove support for VTK8)

  CMake Error at CMake/SlicerBlockInstallExternalPythonModules.cmake:16 (endif):
    Flow control statements are not properly nested.
  Call Stack (most recent call first):
    CMake/SlicerCPack.cmake:172 (include)
    CMake/LastConfigureStep/CMakeLists.txt:44 (include)
@jcfr jcfr force-pushed the fix-cmake-regression-introduced-removing-vtk8-support branch from feeff23 to 8ec576e Compare June 8, 2022 18:00
@jcfr jcfr merged commit 0caa5b1 into Slicer:master Jun 8, 2022
@jcfr jcfr deleted the fix-cmake-regression-introduced-removing-vtk8-support branch June 8, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant