disabled color #177
disabled color #177
Conversation
|
Hey Kanjana Sirinavasatian (@kanjanaSi) this looks really neat :) Can you post some screenshots of this as well? |
| attributedPlaceholder = NSAttributedString( | ||
| string: placeholder, | ||
| attributes: [ | ||
| NSAttributedStringKey.foregroundColor: color, NSAttributedStringKey.font: font |
There was a problem hiding this comment.
Please cleanup this indentation to match what it was before.
There was a problem hiding this comment.
Fixed!
0a09b2e to
76602eb
Compare
|
Awesome :) Would you be up for updating the README.md with documentation and the example project? |
76602eb to
6b06fe3
Compare
|
This control is confusing
It seems to be doing the opposite for me i.e when it's "disabled" the text fields is actually enabled and vice versa |
Hugo Tunius (k0nserv)
left a comment
There was a problem hiding this comment.
Awesome, this looks really good. Lastly could we just add some tests for this new behaviour?
|
Hugo Tunius (@k0nserv) Hi Hugo. Do you have any plan to release this? I was ready to implement this feature and I just found out this PR. |
|
Hey Spyros Zarzonis (@zarzonis) yeah I'll do that right away :) |
|
That's it released. Thanks a bunch Kanjana Sirinavasatian (@kanjanaSi) for the awesome contribution 🎉 |
|
🎉🎉🎉🎉🎉 |
No description provided.