UIAppearance implementation #118
Conversation
|
Brillaint work Martin Wildfeuer (@mwfire). Thanks for the PR, I'm gonna have a look at it later today |
Hugo Tunius (k0nserv)
left a comment
There was a problem hiding this comment.
Could you also add an entry to CHANGELOG.md under the master section crediting yourself and referencing this PR?
| dynamic open var titleFadeInDuration:TimeInterval = 0.2 | ||
| /// The value of the title disappearing duration | ||
| open var titleFadeOutDuration:TimeInterval = 0.3 | ||
| dynamic open var titleFadeOutDuration:TimeInterval = 0.3 |
There was a problem hiding this comment.
I haven't done any UIAppearance customization with Swif, but isn't there a need for a marking such as UI_APPEARANCE_SELECTOR in Objective-C to inform the run time that this can be customized via UIAppearance?
There was a problem hiding this comment.
Annotating properties withdynamic is sufficient to support UIAppearance in Obj-C as well.
|
Sry, my version of changelog was not up-to-date. :/ |
Hugo Tunius (k0nserv)
left a comment
There was a problem hiding this comment.
Could you please also replaces the top comment in all new source files with this https://github.com/Skyscanner/SkyFloatingLabelTextField/blob/master/Sources/SkyFloatingLabelTextField.swift#L1-L7
|
Thanks Martin Wildfeuer (@mwfire) I'm gonna close this PR and perform the merge outside of git so I can clean up some of the commits and resolve the conflicts |
Hey guys,
With this PR I have added the ability to use UIAppearance for global style settings. I recommend to create a new base branch to merge and review this PR, I might have missed something. I added an example and tests. However, I have neither updated the readme nor have I bumped the version.
Let's see if that's of any use for you ;)
Cheers
Martin