Skip to content

Additional module standardization#8516

Merged
APickledWalrus merged 7 commits intodev/featurefrom
feature/additional-module-standardization
Apr 1, 2026
Merged

Additional module standardization#8516
APickledWalrus merged 7 commits intodev/featurefrom
feature/additional-module-standardization

Conversation

@APickledWalrus
Copy link
Copy Markdown
Member

Problem

There remain inconsistencies in our module organization after #8346.
For example, the CommonModule (and its packages) were not updated to use the introduced hierarchy system. It also still has instances of legacy registration.
As another example, the organization of elements is inconsistent across modules. Some use an elements sub package while others do not. Some go further with type-based subpackages while others lump them all together.

Solution

This PR resolves these inconsistencies by using the following guidelines:

  • Syntax implementations are to be stored in a elements/<type> package, such as elements/expressions or elements/effects. elements is to be placed directly in the package of the module.
  • Type classes can be placed in a types subpackage of the module
  • EntityData classes can be placed in an entitydata subpackage of the module
  • Submodules should be used for "things" that are expected to have multiple syntaxes and/or types around them.
    • Consider PlayerModule in EntityModule or BookModule in ItemModule.

I have also moved some ClassInfo registrations into their modules. This PR also fixes an issue where DefaultFunctions were loaded before modules. This could result in some functions failing to load due to the relevant ClassInfos having not yet been registered.

Testing Completed

There are no tests added as this is simply reorganization.

Supporting Information

n/a


Completes: none
Related: none
AI assistance: none

@APickledWalrus APickledWalrus requested review from a team as code owners March 30, 2026 21:54
@APickledWalrus APickledWalrus added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Mar 30, 2026
@APickledWalrus APickledWalrus requested review from Absolutionism, Pesekjak and sovdeeth and removed request for a team March 30, 2026 21:54
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Mar 30, 2026
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to update the code conventions as well and this looks good!

@APickledWalrus APickledWalrus requested a review from sovdeeth March 31, 2026 00:47
@skriptlang-automation skriptlang-automation bot added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Mar 31, 2026
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.15 Releases Mar 31, 2026
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Mar 31, 2026
@APickledWalrus APickledWalrus changed the title Feature/additional module standardization Additional module standardization Apr 1, 2026
@APickledWalrus APickledWalrus merged commit b8676aa into dev/feature Apr 1, 2026
10 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.15 Releases Apr 1, 2026
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Apr 1, 2026
@APickledWalrus APickledWalrus deleted the feature/additional-module-standardization branch April 1, 2026 01:33
@skriptlang-automation skriptlang-automation bot removed the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Awaiting Release

Development

Successfully merging this pull request may close these issues.

4 participants