Fix ExprTagsOf NPE#8512
Merged
APickledWalrus merged 4 commits intoSkriptLang:dev/patchfrom Mar 27, 2026
Merged
Conversation
1 task
Efnilite
approved these changes
Mar 25, 2026
UnderscoreTud
approved these changes
Mar 25, 2026
Member
UnderscoreTud
left a comment
There was a problem hiding this comment.
Proper sanitization should still be applied in PropertyExpression#getAll
APickledWalrus
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ExprTagsOf returns null in get(), which causes an NPE in PropertyExpression getAll()
Solution
Force non-null rule on PropertyExpression and return an empty array in ExprTagsOf
Testing Completed
Manual testing
Supporting Information
Completes: #8494
Related: none
AI assistance: none