Fix effect section errors getting overridden#8498
Merged
APickledWalrus merged 4 commits intodev/patchfrom Mar 27, 2026
Merged
Conversation
sovdeeth
approved these changes
Mar 13, 2026
Member
sovdeeth
left a comment
There was a problem hiding this comment.
Looks good, just want to ensure that errors thrown in the body of the section (eg during loadCode) won't be negatively impacted by this, right?
APickledWalrus
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the section element of an EffectSection errors, but the effect element of it succeeds and later errors due to no syntaxes claiming the section. The user logged errors get overridden by a generic "X is a valid statement but cannot function as a section (:) because there is no syntax in the line to manage it." error.
Solution
Only override the section's error if it doesn't include an explicitly logged error by the user.
Testing Completed
effect section error.skand manual testing.Supporting Information
Quick rundown of what happens:
Completes: none
Related: none
AI assistance: none