Skip to content

Ensure name changers all support set/reset/delete if possible#8432

Merged
sovdeeth merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/unify-item-name-changers
Mar 2, 2026
Merged

Ensure name changers all support set/reset/delete if possible#8432
sovdeeth merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/unify-item-name-changers

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth commented Feb 8, 2026

Problem

clear name of tool wasn't working when type properties were enabled, because the slot changer didn't support delete/reset.

Solution

Ensures all the name type property handlers support all the modes they should. Added delete/reset support to entities, slots, and cleaned up itemtype's

Testing Completed

Supporting Information


Completes: none
Related: none
AI assistance: none

@sovdeeth sovdeeth requested a review from a team as a code owner February 8, 2026 20:37
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Feb 8, 2026
@sovdeeth sovdeeth requested review from Burbulinis and Efnilite and removed request for a team February 8, 2026 20:37
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Feb 8, 2026
@sovdeeth sovdeeth added the needs reviews A PR that needs additional reviews label Feb 12, 2026
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Mar 2, 2026
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Mar 2, 2026
@sovdeeth sovdeeth merged commit a9c9abb into SkriptLang:dev/patch Mar 2, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Mar 2, 2026
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Mar 2, 2026
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Mar 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

3 participants