Patch/fix test crashes#8394
Merged
sovdeeth merged 2 commits intoSkriptLang:dev/patchfrom Jan 22, 2026
Merged
Conversation
Efnilite
approved these changes
Jan 22, 2026
1 task
erenkarakal
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Occasionally, the test server will crash when shutting down due to the last tick of the server taking more than 1 second. This is likely due to the writing of test results being included in the final tick. Velocity unrelated.
Solution
Waits an additional tick before shutting down to ensure the final tick is just the normal shutdown method alone.
Testing Completed
Repeated github actions 10 times in a row without failures.
Supporting Information
Completes: #8388
Related: none
AI assistance: none