Skip to content

Allow ' in specified literals#8382

Merged
APickledWalrus merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/fix-specified-literals
Jan 21, 2026
Merged

Allow ' in specified literals#8382
APickledWalrus merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/fix-specified-literals

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

Problem

dragon's breath (damage cause) was not parsing correctly

Solution

Allows ' in the regex pattern for specified literals.

Testing Completed

Added regression test.

Supporting Information


Completes: #8310
Related: none
AI assistance: none

@sovdeeth sovdeeth requested a review from a team as a code owner January 17, 2026 03:45
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 17, 2026
@sovdeeth sovdeeth requested a review from a team as a code owner January 17, 2026 03:45
@sovdeeth sovdeeth added the 2.14 Targeting a 2.14.X version release. label Jan 17, 2026
@sovdeeth sovdeeth requested review from TheMug06 and UnderscoreTud and removed request for a team January 17, 2026 03:45
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jan 17, 2026
@sovdeeth sovdeeth force-pushed the patch/fix-specified-literals branch from 2133961 to 6eaa780 Compare January 17, 2026 03:49
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Jan 17, 2026
@sovdeeth sovdeeth linked an issue Jan 17, 2026 that may be closed by this pull request
1 task
Copy link
Copy Markdown
Member

@UnderscoreTud UnderscoreTud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be outside the scope of this PR, but would it be possible to check if a value of an enum/registry classinfo uses an illegal character, and maybe warn or error?

@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Jan 17, 2026
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Jan 17, 2026
@APickledWalrus APickledWalrus merged commit ec6728d into SkriptLang:dev/patch Jan 21, 2026
9 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Jan 21, 2026
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Jan 21, 2026
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.14 Targeting a 2.14.X version release. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

Type literal parsing doesn't work on types with spaces

4 participants