Skip to content

Fix display/custom name for entities#8381

Merged
APickledWalrus merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/fix-custom-name
Jan 21, 2026
Merged

Fix display/custom name for entities#8381
APickledWalrus merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/fix-custom-name

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

Problem

display name of entity was returning the CommandSender#getName() value, which is not the same as the Nameable#getCustomName() value previously returned without type properties.

Solution

Ensures display/custom name use getCustomName

Testing Completed

manual verification

Supporting Information


Completes: none
Related: none
AI assistance: none

@sovdeeth sovdeeth requested a review from a team as a code owner January 16, 2026 22:57
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Jan 16, 2026
@sovdeeth sovdeeth requested review from erenkarakal and removed request for a team January 16, 2026 22:57
@sovdeeth sovdeeth added the 2.14 Targeting a 2.14.X version release. label Jan 16, 2026
@sovdeeth sovdeeth requested a review from Burbulinis January 16, 2026 22:57
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jan 16, 2026
@sovdeeth sovdeeth moved this to In Review in 2.14 Releases Jan 16, 2026
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.14 Releases Jan 16, 2026
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jan 17, 2026
@Efnilite Efnilite changed the base branch from master to dev/patch January 17, 2026 13:42
@skriptlang-automation skriptlang-automation bot added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jan 21, 2026
@APickledWalrus APickledWalrus merged commit 8b812e0 into SkriptLang:dev/patch Jan 21, 2026
11 of 13 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jan 21, 2026
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.14 Releases Jan 21, 2026
@skriptlang-automation skriptlang-automation bot removed the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Jan 21, 2026
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.14 Releases Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.14 Targeting a 2.14.X version release. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

Status: Done - Released

Development

Successfully merging this pull request may close these issues.

4 participants