Skip to content

Allow past/future in ExprLevel via default value#8295

Merged
sovdeeth merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/update-expr-level
Dec 1, 2025
Merged

Allow past/future in ExprLevel via default value#8295
sovdeeth merged 2 commits intoSkriptLang:dev/patchfrom
sovdeeth:patch/update-expr-level

Conversation

@sovdeeth
Copy link
Copy Markdown
Member

@sovdeeth sovdeeth commented Nov 22, 2025

Problem

ExprLevel supported past/future values if the default player was used. However, the pattern did not allow the default player, preventing the use of past/future values.

Solution

Used registerDefault instead of register. Improved code quality, added example, added an extra check for changing past/future values in a level change event.

Testing Completed

Manual testing confirmed.

on level change:
    set {_diff} to future xp level - past exp level
    broadcast "%player%'s level changed by %{_diff}%!"
image

Supporting Information

Completes: none
Related: none

@sovdeeth sovdeeth requested a review from a team as a code owner November 22, 2025 09:17
@sovdeeth sovdeeth added the bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. label Nov 22, 2025
@sovdeeth sovdeeth requested review from Pesekjak and TheMug06 and removed request for a team November 22, 2025 09:17
@sovdeeth sovdeeth moved this to In Review in 2.13 Releases Nov 22, 2025
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Nov 22, 2025
@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.13 Releases Dec 1, 2025
@skriptlang-automation skriptlang-automation bot added patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. and removed needs reviews A PR that needs additional reviews labels Dec 1, 2025
@sovdeeth sovdeeth merged commit a8cec28 into SkriptLang:dev/patch Dec 1, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done - Awaiting Release in 2.13 Releases Dec 1, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. labels Dec 1, 2025
@sovdeeth sovdeeth moved this from Done - Awaiting Release to Done - Released in 2.13 Releases Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@APickledWalrus APickledWalrus APickledWalrus approved these changes

@erenkarakal erenkarakal erenkarakal approved these changes

@Pesekjak Pesekjak Awaiting requested review from Pesekjak Pesekjak is a code owner automatically assigned from SkriptLang/core-developers

@TheMug06 TheMug06 Awaiting requested review from TheMug06 TheMug06 is a code owner automatically assigned from SkriptLang/core-developers

Assignees

No one assigned

Labels

bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update.

Projects

No open projects
2.13 Releases
Status: Done - Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sovdeeth @APickledWalrus @erenkarakal